fix(idx): allow flow entry point request when use generic remediator (beta) #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,7 +92,8 @@ describe('remediators/GenericRemediator', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('nested inputs', () => { | |||
| // Re-enable when add client side validation in GenericRemediator | |||
There was a problem hiding this comment.
Can you add a JIRA for this and put the ID in the comment?
There was a problem hiding this comment.
This feature may not be needed depend on which approach siw-next will pick to implement client side validation (auth-js vs ajv). Will the jira still be needed for uncertain works?
aarongranick-okta
approved these changes
Jul 5, 2022
shuowu-okta
force-pushed
the
sw-fix-generic-remediator-flow-entry-request
branch
from
29ba8d8
to
be411d0
Compare
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Jul 5, 2022
…(beta) OKTA-512298 <<<Jenkins Check-In of Tested SHA: be411d0 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 4 PR Link: #1251
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Jul 5, 2022
OKTA-512298 <<<Jenkins Check-In of Tested SHA: be411d0 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 4 PR Link: #1251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.