Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore signature not set in get with redirect #161

Conversation

ivanryuu
Copy link
Contributor

@ivanryuu ivanryuu commented Oct 8, 2018

Resolves the issue described in #160

ivanryuu and others added 3 commits October 7, 2018 20:02
Adds ignoreSignature to the cookie in token.getWithRedirect

Resolves: okta#160
Fixes breaking tests expecting an ignoreSignature value in the cookie

Resolves: okta#160
Copy link
Contributor

@jmelberg-okta jmelberg-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for this change @ivanryuu!

@jmelberg-okta jmelberg-okta merged commit 074dca7 into okta:master Oct 12, 2018
@ivanryuu
Copy link
Contributor Author

@jmelberg-okta Is there an estimate for when the next release is coming?

@ivanryuu ivanryuu deleted the ignore-signature-not-set-in-get-with-redirect branch October 31, 2018 21:55
@jmelberg-okta
Copy link
Contributor

Hi @ivanryuu -

Thanks for your patience. We're working on a couple more changes to this library before releasing a new version. I'll try to close those out within the next day or so. Once that is complete, I'll release a new minor version of this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants