fix: Fixes an issue where default storage was read-only #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/storageUtil.js
Outdated
| @@ -22,7 +22,8 @@ var storageUtil = {}; | |||
| // https://connect.microsoft.com/IE/Feedback/Details/1496040 | |||
| storageUtil.browserHasLocalStorage = function() { | |||
| try { | |||
| if (storageUtil.getLocalStorage()) { | |||
| var storage = storageUtil.getLocalStorage(); | |||
| if (storageUtil.testStorage(storage)) { | |||
There was a problem hiding this comment.
nit: return storageUtil.testStorage(storage)
| @@ -73,4 +75,15 @@ storageUtil.getCookieStorage = function() { | |||
| }; | |||
| }; | |||
|
|
|||
| storageUtil.testStorage = function(storage) { | |||
There was a problem hiding this comment.
wonder if it's worth to check null-able of storage?
There was a problem hiding this comment.
I thought about that as well. Attempting to call setItem on undefined or null will throw a TypeError, which will result in returning false. I think we should be safe thanks to wrapping this in a try catch
haishengwu-okta
approved these changes
Nov 6, 2018
jmelberg-okta
added a commit
that referenced
this pull request
Nov 12, 2018
This reverts commit c384006.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where checking if
localStorageand/orsessionStoragewas returningtrue, even though it cannot be written to.See:
Example
Here is an example using iOS 10 Safari: