Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add babel, browserslist. eslint for browser compatibility #306

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Add babel, browserslist. eslint for browser compatibility #306

merged 1 commit into from
Jan 14, 2020

Conversation

aarongranick-okta
Copy link
Contributor

  • remove vender/polyfills - we should not polyfill within a library. Also these polyfills are not necessary with supported browser versions.
  • remove browser: true from eslint config so we must explicitly declare browser globals
  • add eslint-plugin-compat which uses our browserslist config to produce lint errors if we have incompatible code
  • adds babel (which has no effect at this time since all code is ES5)

@aarongranick-okta aarongranick-okta merged commit e3df546 into v3.0 Jan 14, 2020
@aarongranick-okta aarongranick-okta deleted the ag-babel-OKTA-218652 branch January 14, 2020 20:09
aarongranick-okta added a commit that referenced this pull request Jan 15, 2020
@aarongranick-okta
Add babel, browserslist. eslint for browser compatibility (#306)
0a08bf9
aarongranick-okta added a commit that referenced this pull request Jan 15, 2020
@aarongranick-okta
Add babel, browserslist. eslint for browser compatibility (#306)
e7021e6
aarongranick-okta added a commit that referenced this pull request Jan 21, 2020
@aarongranick-okta
Add babel, browserslist. eslint for browser compatibility (#306)
eb33c68
aarongranick-okta added a commit that referenced this pull request Jan 21, 2020
@aarongranick-okta
version 3.0.0
28a83f5 
Add babel, browserslist. eslint for browser compatibility (#306)

chore : remove Q, replace with standard Promise (#309)

feat: signOut uses redirect method. new method closeSession (#310)
@aarongranick-okta aarongranick-okta mentioned this pull request Jan 31, 2020
Merged
@aarongranick-okta aarongranick-okta mentioned this pull request Mar 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiftone swiftone swiftone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarongranick-okta @swiftone