fix: responseType=code: return code, support pkce=false #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiftone
reviewed
Mar 27, 2020
| @@ -229,16 +229,18 @@ function handleOAuthResponse(sdk, oauthParams, res, urls) { | |||
|
|
|||
| var scopes = util.clone(oauthParams.scopes); | |||
| var clientId = oauthParams.clientId || sdk.options.clientId; | |||
| var pkce = sdk.options.pkce !== false; | |||
There was a problem hiding this comment.
nit: isPkce or hasPkce or usesPkce?
swiftone
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for non-SPA applications, using authorization_code flow. Generally these apps will process the code server-side and so will not need to call
parseFromUrl, but if they do they will receive an error. This fixes the logic so the code will not be exchanged for a token if pkce=false. The code will be returned.