-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.0 release #412
4.0 release #412
Conversation
45b2dff
to
1c9ab9e
Compare
209bb11
to
9a65e52
Compare
1a9abf5
to
4a81e55
Compare
* move module from packages to repo root * rename browser/server index * update eslint, use ecmaVersion 2020
* feat: support typescript, use named exports
implements active autoRenew
4a81e55
to
e8223e0
Compare
@@ -138,10 +142,17 @@ npm install --save @okta/okta-auth-js | |||
|
|||
If you are using the JS on a web page from the browser, you can copy the `node_modules/@okta/okta-auth-js/dist` contents to publicly hosted directory, and include a reference to the `okta-auth-js.min.js` file in a `<script>` tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace this part with the cdn url?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but we have to do this in a follow up, unless we want to reference version 3. version 4 is not on the CDN yet. The named export change actually doesn't effect CDN users, I am building a special bundle that exports in the same way as version 3, so OktaAuth
(the constructor) is a window global.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or with a placeholder in the URL, not sure if it's a good idea...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a task to follow up on this: https://oktainc.atlassian.net/browse/OKTA-322506 I think we can include URLs for current and previous version and describe how to choose the latest version (in case we don't keep it up to date).
No description provided.