fix: mutiple tabs login issue #473
Conversation
lib/token.ts
Outdated
| responseType, | ||
| state, | ||
| nonce, | ||
| scopes, | ||
| clientId, | ||
| urls: urls, | ||
| ignoreSignature | ||
| }), null, sdk.options.cookies); | ||
| }); | ||
| if (browserStorage.browserHasSessionStorage()) { |
There was a problem hiding this comment.
I feel like this if/else block should be pulled out to a separate function.
lib/token.ts
Outdated
| if (!oauthParamsCookie) { | ||
| return Promise.reject(new AuthSdkError('Unable to retrieve OAuth redirect params cookie')); | ||
| let oauthParamsStr; | ||
| if (browserStorage.browserHasSessionStorage()) { |
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
==========================================
- Coverage 90.31% 90.13% -0.19%
==========================================
Files 31 31
Lines 1549 1561 +12
Branches 340 342 +2
==========================================
+ Hits 1399 1407 +8
- Misses 150 154 +4
Continue to review full report at Codecov.
|
lib/token.ts
Outdated
| @@ -673,17 +673,22 @@ function getWithRedirect(sdk: OktaAuth, options: TokenParams): Promise<void> { | |||
| var urls = getOAuthUrls(sdk, options); | |||
| var requestUrl = urls.authorizeUrl + buildAuthorizeParams(tokenParams); | |||
|
|
|||
| // Set session cookie to store the oauthParams | |||
| // Store the oauthParams in storage for re-visiting when redirect back | |||
There was a problem hiding this comment.
I think this code would only be used in front end SDKs, not by the widget, so there's no concern with having duplicate and out-of-sync copies of auth-js, but I'd be happier if someone else explicitly agreed
| @@ -2505,7 +2505,7 @@ describe('token.parseFromUrl', function() { | |||
| '&expires_in=3600' + | |||
| '&token_type=Bearer' + | |||
| '&state=' + oauthUtil.mockedState, | |||
| oauthCookie: JSON.stringify({ | |||
| oauthParams: JSON.stringify({ | |||
| responseType: 'token', | |||
| state: 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa', | |||
There was a problem hiding this comment.
"Do you hear that sound, Fezzik?"
Adding it, need a pr link first. |
Use sessionStorage (if available in browser) as default storage for
okta-oauth-redirect-paramsChecked in okta repos and readme of auth-js, didn't find usage of
okta-oauth-redirect-paramscookie.