Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS issues with transformAuthState #947

Closed

Conversation

denysoblohin-okta
Copy link
Contributor

@denysoblohin-okta denysoblohin-okta commented Sep 22, 2021

  • Allow custom keys in AuthState interface
  • Use OktaAuth class instead of interface for transformAuthState, restoreOriginalUri

Internal ref: OKTA-379786
Resolves #667

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #947 (4fb6c25) into master (be69e5f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #947   +/-   ##
=======================================
  Coverage   92.11%   92.11%           
=======================================
  Files         120      120           
  Lines        3412     3412           
  Branches      702      702           
=======================================
  Hits         3143     3143           
  Misses        269      269           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be69e5f...4fb6c25. Read the comment docs.

Copy link
Contributor

@shuowu shuowu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add changelog, this one can be an additive feature change.

@denysoblohin-okta
Copy link
Contributor Author

Added changelog

@denysoblohin-okta denysoblohin-okta force-pushed the od-OKTA-379786-ts-transformAuthState branch from 202348b to f098bea Compare September 24, 2021 19:22
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Sep 24, 2021
TS: First argument for transformAuthState, restoreOriginalUri methods is now instance of OktaAuth class instead of interface

OKTA-379786
<<<Jenkins Check-In of Tested SHA: f098bea for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-auth-js
Files changed count: 4
PR Link: "#947"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transformAuthState option has incorrect TS interface
4 participants