Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error in parseFromUrl() if can't load transaction meta #967

Closed
wants to merge 2 commits into from

Conversation

denysoblohin-okta
Copy link
Contributor

@denysoblohin-okta denysoblohin-okta commented Oct 6, 2021

Resolves #895

If loading of OAuth params from storage fails (eg. if legacyWidgetSupport is off and no transaction meta), throw a corresponding error

Internal ref: OKTA-418956

Copy link
Contributor

@shuowu shuowu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a changelog for it. We can release it in 5.6

eng-prod-CI-bot-okta pushed a commit that referenced this pull request Oct 8, 2021
OKTA-418956
<<<Jenkins Check-In of Tested SHA: bd7d2f5 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-auth-js
Files changed count: 3
PR Link: "#967"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException in parseFromUrl
3 participants