Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple issues #190

Merged
merged 4 commits into from
Jan 4, 2023

Conversation

laura-rodriguez
Copy link
Collaborator

@laura-rodriguez laura-rodriguez commented Dec 15, 2022

@laura-rodriguez laura-rodriguez changed the title Fix OKTA-509616 - Issue with Phone factor when enrolled with multiple contact numbers Fix multiple issues Jan 3, 2023
@laura-rodriguez laura-rodriguez marked this pull request as ready for review January 3, 2023 21:39
Copy link
Contributor

@bryanapellanes-okta bryanapellanes-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, but approved 👍

Name = authenticator?.DisplayName,
MethodTypes = authenticator?.Methods?.Select(x => x.Type).ToList(),
EnrollmentId = enrollment?.Id,
Profile = (enrollment != null) ? GetAuthenticatorProfile(enrollment) : string.Empty,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these parenthesis redundant?

@laura-rodriguez laura-rodriguez merged commit 9eb737a into master Jan 4, 2023
@laura-rodriguez laura-rodriguez deleted the lr-OKTA-509616-phone-with-multiple-numbers branch January 4, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants