Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

Add support for failure redirect #102

Closed
ahmednasir91 opened this issue Jan 30, 2018 · 3 comments
Closed

Add support for failure redirect #102

ahmednasir91 opened this issue Jan 30, 2018 · 3 comments

Comments

@ahmednasir91
Copy link

PassportJS has a failureRedirect route which can be provided by client to show a custom error page.

The case i've is if you hit authorization-code/callback?error=access_denied if will just show Unauthorized and not an easy way to override this error page or show a page.

I propose, provided the clients ability to provide failureRedirect for passport similar to successReturnToOrRedirect.

@ahmednasir91
Copy link
Author

Let me know your thoughts about this change
ahmednasir91@aeb7d37

I can create a pull request, if this looks good.

@robertjd
Copy link
Contributor

robertjd commented Feb 7, 2018

Thanks @ahmednasir91 , this looks good and I'd love to see a PR. With that PR can you also document this option in the README? I'll also need to send you over to our CLA before we can merge: https://developer.okta.com/cla/

Thanks again!

@ahmednasir91
Copy link
Author

@robertjd created a pull request #118

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants