Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

SecureRoute exact=true #70

Closed
rogeralsing opened this issue Dec 2, 2017 · 2 comments
Closed

SecureRoute exact=true #70

rogeralsing opened this issue Dec 2, 2017 · 2 comments

Comments

@rogeralsing
Copy link

In SecureRoute.js

return <Route path={this.props.path} render={this.renderWrapper} />;

There is no way to specify additional route props, e.g. exact

@mschaeffner
Copy link

mschaeffner commented Mar 12, 2018

I'd suggest that all props are passed down to Route, because SecureRoute should just act like a proxy to ensure authentication. I could create a pull request for this. But first, I'd like to see my PR_139 (#139) merged into master, as this also deals with SecureRoute, and I try to avoid merge conflicts later on.

@jmelberg-okta
Copy link
Contributor

Thanks for the input all!

This issue is now resolved with #279 and released under @okta/okta-react@1.1.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants