Add loadingComponent prop to LoginCallback component #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be great to cover the loading scenario in jest and e2e test. |
aarongranick-okta
requested changes
Dec 24, 2020
|
Is there an estimate of when this will land? I currently manually handle this functionality. |
|
Internal Ref: OKTA-404404 |
denysoblohin-okta
force-pushed
the
br-hat-pub-add-loading-to-login
branch
from
9efdd45
to
8e77c97
Compare
denysoblohin-okta
approved these changes
Jul 6, 2021
shuowu
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoting original PR( #58 ) from @ericlifs:
Actual result
The LoginCallback components shows an empty white page while the authentication is being performed
What this PR does
This PR gives the developer the possibility to set any custom component that he/she wants to show while Okta's authentication is being done instead of just returning a null value