Add better argument checking for null/empty strings when constructing URLs

[gantzm]

Seeing the following when calling client.getUser("string value").

It doesn't appear that this is something I can control.

I'm assuming the client is thread safe, is it not maybe?

java.lang.IllegalArgumentException: It is expected that only ArrayProperty or SetProperty properties represent collection items.
at com.okta.sdk.lang.Assert.isTrue(Assert.java:33)
at com.okta.sdk.impl.ds.cache.WriteCacheFilter.cache(WriteCacheFilter.java:154)
at com.okta.sdk.impl.ds.cache.WriteCacheFilter.filter(WriteCacheFilter.java:73)
at com.okta.sdk.impl.ds.DefaultFilterChain.filter(DefaultFilterChain.java:52)
at com.okta.sdk.impl.ds.cache.ReadCacheFilter.filter(ReadCacheFilter.java:53)
at com.okta.sdk.impl.ds.DefaultFilterChain.filter(DefaultFilterChain.java:52)
at com.okta.sdk.impl.ds.DefaultDataStore.getResourceData(DefaultDataStore.java:309)
at com.okta.sdk.impl.ds.DefaultDataStore.getResource(DefaultDataStore.java:225)
at com.okta.sdk.impl.ds.DefaultDataStore.getResource(DefaultDataStore.java:213)
at com.okta.sdk.impl.client.DefaultClient.getUser(DefaultClient.java:236)

[bdemers]

@gantzm thanks for reporting this.

I'm trying to figure out how to reproduce. Is your "string value" an valid user id or are you literally using "string value"?

[gantzm]

Some debugging reveals that the call being made was client.getUser(""), with an empty string.

Probably not a valid scenario, but an argument check would probably be helpful.

[bdemers]

Agreed! We will get some added checking in there!
I'm going to change the name of this issue to reflect this.

[bdemers]

I'm assuming that getting a user with an id of "" is actually getting list of users from /users which would return a collection. We should guard against this, as that is not a valid arg for this method (or any 'id' based get method)