Removes IE11 incompatible code from v1/EnrollChoicesController
#3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawyu-okta
requested review from
sherizada-okta,
mauriciocastillosilva-okta,
magizh-okta,
robertdamphousse-okta,
TianGan-okta,
aarongranick-okta,
shuowu-okta,
lesterchoi-okta,
jaredperreault-okta,
vijetmahabaleshwar-okta,
venkatakommisetty-okta and
glenfannin-okta
as code owners
shawyu-okta
force-pushed
the
sy-enroll-choices-ie11-okta-599424
branch
from
de2a95a
to
6ddd62c
Compare
shawyu-okta
force-pushed
the
sy-enroll-choices-ie11-okta-599424
branch
from
6ddd62c
to
d1bfd09
Compare
shawyu-okta
commented
Jun 14, 2023
| return Number.isInteger(remainingDays) && remainingDays >= 0 | ||
|
|
||
| // remainingDays is null if there is no grace period, 0 if we are still in grace period | ||
| return (remainingDays !== null && remainingDays >= 0) |
There was a problem hiding this comment.
See https://github.com/okta/okta-signin-widget/pull/770/files#r308359100 -- we were using isInteger as a proxy for checking if remainingDays !== null. We can assume that if it's not null then it will be a number and then assume that its an integer.
glenfannin-okta
approved these changes
Jun 14, 2023
eng-services-aperture-github-bot-okta
deleted the
sy-enroll-choices-ie11-okta-599424
branch
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
PR Checklist
Issue:
Reviewers:
Screenshot/Video:
Downstream Monolith Build: