feat: update samples to support vue 3 - OKTA-364845 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuowu-okta
commented
Jan 29, 2021
custom-login/package.json
Outdated
| "axios": "^0.20.0", | ||
| "@okta/okta-auth-js": "^4.6.1", | ||
| "@okta/okta-signin-widget": "^5.2.3", | ||
| "@okta/okta-vue": "git://github.com/okta/okta-vue.git#sw-support-vue-3-OKTA-353048", |
There was a problem hiding this comment.
need to be updated to 4.0 or dev-4.0 branch when the PR in okta-vue get merged (before okta-vue@4.0 release)
shuowu-okta
commented
Jan 29, 2021
okta-hosted-login/package.json
Outdated
| "@okta/okta-vue": "^3.0.0", | ||
| "axios": "^0.20.0", | ||
| "@okta/okta-auth-js": "^4.6.1", | ||
| "@okta/okta-vue": "git://github.com/okta/okta-vue.git#sw-support-vue-3-OKTA-353048", |
There was a problem hiding this comment.
need to be updated to 4.0 or dev-4.0 branch when the PR in okta-vue get merged (before okta-vue@4.0 release)
shuowu-okta
commented
Jan 29, 2021
README.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| # Vue Sample Applications for Okta | |||
|
|
|||
| > Note: You're currently looking at sample applications that support Vue 3. If you are looking for samples for Vue 2, please checkout the [main branch](https://github.com/okta/samples-js-vue). | |||
There was a problem hiding this comment.
After this PR gets merged into the vue-3 branch, we can add a similar note in the main branch.
shuowu-okta
force-pushed
the
sw-add-vue-3-samples-OKTA-364845
branch
from
f0d6176
to
87cf974
Compare
aarongranick-okta
approved these changes
Apr 26, 2021
vijetmahabaleshwar-okta
force-pushed
the
sw-add-vue-3-samples-OKTA-364845
branch
3 times, most recently
from
8d50a93
to
49dff3e
Compare
Closed
shuowu-okta
force-pushed
the
sw-add-vue-3-samples-OKTA-364845
branch
from
1f03894
to
2310b70
Compare
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Jun 10, 2021
update okta-vue to v4 Adds onAuthResume handler Updates auth-js dependency to 4.9.2 update readme to indicate vue-2 branch for vue 2 samples update lock file update root level readme to indicate vue-2 branch chore: add vue-loader-v16 to devDeps OKTA-364845 <<<Jenkins Check-In of Tested SHA: 60b805c for eng_productivity_ci_bot_okta@okta.com>>> Artifact: samples-js-vue Files changed count: 31 PR Link: "#104"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.