Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed articulate okta SDK #215

Merged
merged 9 commits into from
Nov 14, 2020
Merged

Conversation

bogdanprodan-okta
Copy link
Contributor

No description provided.

@bryantbiggs
Copy link
Contributor

this looks awesome, incredible work @bogdanprodan-okta - @noinarisak any chance we could get this merged and released under v3.6.1 today?

…okta into rip_out_articulate_okta

� Conflicts:
�	okta/app.go
@bogdanprodan-okta
Copy link
Contributor Author

this looks awesome, incredible work @bogdanprodan-okta - @noinarisak any chance we could get this merged and released under v3.6.1 today?

We are still waiting for a new version okta-sdk-golang to be published, as it contains a fix related to the rate-limiting issue.

@bryantbiggs
Copy link
Contributor

@bogdanprodan-okta is this the patch that we're waiting on okta/okta-sdk-golang#182 ?

@bogdanprodan-okta
Copy link
Contributor Author

@bogdanprodan-okta is this the patch that we're waiting on okta/okta-sdk-golang#182 ?

Yes, it is

@bryantbiggs
Copy link
Contributor

sorry to be a pain, but it looks like the changes landed -https://github.com/okta/okta-sdk-golang/releases/tag/v2.2.0 - just hoping to get some of these fixes in because I am importing a large amount of changes for a client and these will help a lot of issues we are seeing in the diffs

@bogdanprodan-okta
Copy link
Contributor Author

I will merge this PR within several hours, just need to be sure that all the acceptance tests will pass.

@bryantbiggs
Copy link
Contributor

@bogdanprodan-okta / @noinarisak could we get a new release with the number of changes since v3.6.0 when you get a chance, please?

@bogdanprodan-okta
Copy link
Contributor Author

@bogdanprodan-okta / @noinarisak could we get a new release with the number of changes since v3.6.0 when you get a chance, please?

Hi @bryantbiggs! Today we will release these changes with tag v3.6.1

@bogdanprodan-okta bogdanprodan-okta deleted the rip_out_articulate_okta branch November 19, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants