Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Github PR Previews #12

Closed
maroshii opened this issue Jan 26, 2022 · 4 comments · Fixed by #20
Closed

Documentation for Github PR Previews #12

maroshii opened this issue Jan 26, 2022 · 4 comments · Fixed by #20
Assignees

Comments

@maroshii
Copy link
Contributor

As part of the preview environment github integration we need to update the docs to properly document the auto previews PR integration.

This is the page: https://www.okteto.com/docs/cloud/preview-environments/preview-environments-github/

Not sure if the idea is to deprecate the github action or not but we would need to either replace the page or create a new one.

@jmacelroy
Copy link
Contributor

@RinkiyaKeDad can you assist on this one? We are working on getting together a list of permissions we require from GitHub, via oauth, and why we need them. We will be including those perms in an email but we will also need them in the documentation. @maroshii can work with you on an overview of the feature and how it works, also you can use it in staging.

@maroshii
Copy link
Contributor Author

We request the following permissions:

Screen Shot 2022-02-23 at 8 17 20 PM


PR previews added Pull Request: read & write and Commit Statuses: read & write, all the other permissions where already in place.

Note that upon signing up only the user permission email is requested, for the rest the user needs to install the github app as part of the deploy (dev) or add repo (previews) modal.

The messages below are not meant to be what we show to the user but a guideline to why we need them.

Why do we need them:

Repo

Repo Contents - To clone repos and deploy preview and dev environments from private repositories.
Metadata -List repositories for orgs and users.
Pull Request (new) - To post PR messages with preview environment info (endpoints, etc)
Commit Statuses (new) - To create PR checks for preview environments

Organizations

Members - Requested only for org installations. Not sure exactly why we need them, maybe @ifbyol can shed some light here.

User

Email - During signup. To be able to link the okteto user to the github account.

@RinkiyaKeDad
Copy link
Member

Sure I can work on this. Could you please remind me again what the timeline for shipping this feature is?

@jmacelroy
Copy link
Contributor

Sure I can work on this. Could you please remind me again what the timeline for shipping this feature is?

We hope to ship it next week. There are a few tasks we need to finish before the launch. It includes an email and the documentation listed here. We can sync next week to go over details as I need to review and create the final issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants