Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename launch → deploy #572

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

viddo
Copy link
Contributor

@viddo viddo commented Dec 28, 2023

Updates wording to "Deploy Dev Environment" from prev "Launch …".

Note that there are still more instances that use the word "launch" but more so in the general sense than specifically related to the rename related to the Deploy dialog specifically, so left them as-is. Please advice if you think we should also update such sentences.

For new screenshots in affected docs applied a -v1.17+ suffix in the filename, to indicate that they are intended from v1.17 and forward and not break older versioned and archived docs.

To see difference with prev docs, compare with existing images (w/o suffix) or review preview env with live docs, e.g. /deploy/launch-from-catalog/ and sibling docs.

Updated redirects and current v1.16 docs files/and URLs to also match and work for next/1.17 version docs. It's necessary because Netlify and the redirects doesn't have any notion of our versioning mechanism, and otherwise would break when we switch from v1.16 → v1.17 for current/default docs version.

Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for okteto-docs ready!

Name Link
🔨 Latest commit f31533f
🔍 Latest deploy log https://app.netlify.com/sites/okteto-docs/deploys/65947a43bd76f10008ef7377
😎 Deploy Preview https://deploy-preview-572--okteto-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@viddo viddo requested a review from bgonp December 28, 2023 12:36
@viddo
Copy link
Contributor Author

viddo commented Dec 28, 2023

Note that need to switch to v1.17 to see new screenshots in use, e.g. https://deploy-preview-572--okteto-docs.netlify.app/docs/1.17/deploy/deploy-from-catalog/

@viddo
Copy link
Contributor Author

viddo commented Dec 28, 2023

BTW, heads up; I'll be on vacation all of next week/1st week of January - feel free to modify and merge PR before I'm back (Mon Jan 8th)

Copy link
Contributor

@omnomagonz omnomagonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Made one minor change to fix a typo. Otherwise looks ready to ship 👍

@viddo viddo merged commit 5d7bedb into main Jan 8, 2024
4 checks passed
@viddo viddo deleted the nicklas/LAKE-145/rename-launch-deploy branch January 8, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants