Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toogle-group): tabindex #345

Merged
merged 3 commits into from
Sep 9, 2023
Merged

fix(toogle-group): tabindex #345

merged 3 commits into from
Sep 9, 2023

Conversation

productdevbook
Copy link
Member

Description

Linked Issues

close #304

Additional context

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023 •
edited
Loading

Thank you for following the naming conventions! 🙏

@productdevbook productdevbook marked this pull request as draft September 9, 2023 15:04
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 86.11% 5061 / 5877
🔵 Statements 86.11% 5061 / 5877
🔵 Functions 72.72% 176 / 242
🔵 Branches 83.94% 387 / 461
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/checkbox/src/checkbox.ts 86.8% 79.31% 72.72% 86.8% 131, 153-156, 181, 183-185, 193-199, 206-220
packages/components/roving-focus/src/RovingFocusGroup.ts 100% 100% 100% 100%
packages/components/roving-focus/src/RovingFocusGroupImpl.ts 78.88% 100% 14.28% 78.88% 81-82, 95, 98-99, 110-111, 113-114, 119-120, 136, 138, 141, 143-164, 167, 169
packages/components/roving-focus/src/RovingFocusGroupItem.ts 72.94% 87.5% 40% 72.94% 87-89, 108, 110-115, 118, 120, 123, 125-157
packages/components/toggle/src/toggle.ts 98.54% 85.71% 88.88% 98.54% 89, 92
Generated in workflow #834

@productdevbook productdevbook marked this pull request as ready for review September 9, 2023 15:24
@productdevbook productdevbook merged commit 15a6d44 into main Sep 9, 2023
6 checks passed
@productdevbook productdevbook deleted the fix-toggle-9 branch September 9, 2023 15:28
This was referenced Sep 9, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dammy001 dammy001 Awaiting requested review from dammy001

@kbrkiras kbrkiras Awaiting requested review from kbrkiras

@YeSuX YeSuX Awaiting requested review from YeSuX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

toggle group tabindex dont change
1 participant
@productdevbook