Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: all component onUnmounted to onBeforeUnmount #368

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix: all component onUnmounted to onBeforeUnmount #368

merged 1 commit into from
Sep 19, 2023

Conversation

productdevbook
Copy link
Member

Description

Linked Issues

Additional context

@github-actions
Copy link
Contributor

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 88.65% 6528 / 7363
🔵 Statements 88.65% 6528 / 7363
🔵 Functions 76.36% 223 / 292
🔵 Branches 88.6% 614 / 693
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/dismissable-layer/src/DismissableLayer.ts 47.26% 100% 0% 47.26% 142-305
packages/components/presence/src/usePresence.ts 76.02% 75% 71.42% 76.02% 48, 54-67, 81-91, 94-97, 121-122, 137-139
packages/core/use-composable/src/useSize.ts 53.12% 75% 100% 53.12% 20-46, 51-53
Generated in workflow #904

@productdevbook productdevbook merged commit fa14a9e into main Sep 19, 2023
6 checks passed
@productdevbook productdevbook deleted the fix-onUnmounted branch September 19, 2023 05:19
@github-actions github-actions bot mentioned this pull request Sep 19, 2023
Merged
@github-actions github-actions bot mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cr0zy07 Cr0zy07 Cr0zy07 approved these changes

@dammy001 dammy001 Awaiting requested review from dammy001

@YeSuX YeSuX Awaiting requested review from YeSuX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@productdevbook @Cr0zy07