Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vmbridge script #3106

Merged
merged 4 commits into from
May 11, 2023
Merged

Add vmbridge script #3106

merged 4 commits into from
May 11, 2023

Conversation

BaZahei
Copy link
Contributor

@BaZahei BaZahei commented Apr 14, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2023

Codecov Report

Merging #3106 (cfb9b27) into dev (e3ad5e5) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head cfb9b27 differs from pull request most recent head f2f3084. Consider uploading reports for the commit f2f3084 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev    #3106   +/-   ##
=======================================
  Coverage   35.82%   35.82%           
=======================================
  Files         437      437           
  Lines       46060    46060           
=======================================
+ Hits        16500    16502    +2     
+ Misses      28351    28350    -1     
+ Partials     1209     1208    -1     

see 1 file with indirect coverage changes

BananaLF
BananaLF previously approved these changes May 11, 2023
@KamiD KamiD merged commit b3b958c into dev May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants