Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm rpc #3109

Merged
merged 3 commits into from
Apr 20, 2023
Merged

wasm rpc #3109

merged 3 commits into from
Apr 20, 2023

Conversation

ilovers
Copy link
Contributor

@ilovers ilovers commented Apr 18, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@ilovers ilovers marked this pull request as draft April 18, 2023 10:13
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Merging #3109 (677366a) into dev (b7f3994) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 677366a differs from pull request most recent head 1916dc4. Consider uploading reports for the commit 1916dc4 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev    #3109      +/-   ##
==========================================
- Coverage   35.90%   35.87%   -0.04%     
==========================================
  Files         434      435       +1     
  Lines       45786    45830      +44     
==========================================
  Hits        16441    16441              
- Misses      28154    28198      +44     
  Partials     1191     1191              
Impacted Files Coverage Δ
app/rpc/namespaces/eth/api.go 0.00% <0.00%> (ø)
app/rpc/namespaces/eth/wasm.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ilovers ilovers closed this Apr 20, 2023
@ilovers ilovers reopened this Apr 20, 2023
@ilovers ilovers changed the base branch from dev to e2c_wasm April 20, 2023 09:58
@ilovers ilovers merged commit c2f87e8 into e2c_wasm Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants