Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fq: fix simulate wasm #3129

Merged
merged 5 commits into from
May 16, 2023
Merged

fq: fix simulate wasm #3129

merged 5 commits into from
May 16, 2023

Conversation

scf0220
Copy link
Contributor

@scf0220 scf0220 commented May 8, 2023

simulate wasm fq

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

simulate wasm fq
ilovers
ilovers previously approved these changes May 9, 2023
@ilovers ilovers requested review from yann-sjtu and BananaLF May 9, 2023 09:08
@scf0220 scf0220 changed the title fix: simulate wasm fq fq: fix simulate wasm May 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Merging #3129 (b108d18) into dev (ea94391) will increase coverage by 0.01%.
The diff coverage is 81.39%.

❗ Current head b108d18 differs from pull request most recent head 35ee4a6. Consider uploading reports for the commit 35ee4a6 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev    #3129      +/-   ##
==========================================
+ Coverage   35.82%   35.83%   +0.01%     
==========================================
  Files         437      437              
  Lines       46060    46058       -2     
==========================================
+ Hits        16500    16504       +4     
+ Misses      28351    28346       -5     
+ Partials     1209     1208       -1     
Impacted Files Coverage Δ
x/wasm/keeper/querier.go 70.04% <0.00%> (ø)
x/wasm/simulate.go 0.00% <0.00%> (ø)
x/wasm/keeper/keeper.go 80.14% <92.10%> (+0.33%) ⬆️

ilovers
ilovers previously approved these changes May 11, 2023
@KamiD KamiD merged commit a5c9d0c into dev May 16, 2023
@scf0220 scf0220 deleted the scf/0427-wasm-sim branch June 7, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants