Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support go 1.20 #3137

Merged
merged 8 commits into from
Jun 7, 2023
Merged

support go 1.20 #3137

merged 8 commits into from
Jun 7, 2023

Conversation

chengzhinei
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Merging #3137 (2c5e0bf) into dev (b3b958c) will increase coverage by 0.25%.
The diff coverage is 73.51%.

❗ Current head 2c5e0bf differs from pull request most recent head ebfbd45. Consider uploading reports for the commit ebfbd45 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev    #3137      +/-   ##
==========================================
+ Coverage   35.82%   36.07%   +0.25%     
==========================================
  Files         437      441       +4     
  Lines       46060    46306     +246     
==========================================
+ Hits        16500    16705     +205     
- Misses      28351    28363      +12     
- Partials     1209     1238      +29     
Impacted Files Coverage Δ
x/evm/txs/base/common.go 17.02% <0.00%> (-0.38%) ⬇️
x/wasm/keeper/contract_keeper.go 55.00% <0.00%> (-6.12%) ⬇️
x/evm/keeper/keeper.go 58.11% <50.00%> (-0.15%) ⬇️
x/vmbridge/types/precompile.go 65.00% <65.00%> (ø)
x/vmbridge/keeper/precompile.go 67.16% <67.16%> (ø)
x/vmbridge/keeper/wasm.go 67.08% <71.42%> (-1.03%) ⬇️
x/evm/types/state_transition.go 64.08% <77.77%> (+0.21%) ⬆️
x/evm/types/statedb_protect.go 78.04% <78.04%> (ø)
app/app.go 81.88% <100.00%> (+0.03%) ⬆️
x/evm/types/abi.go 79.41% <100.00%> (+6.33%) ⬆️
... and 4 more

... and 2 files with indirect coverage changes

@KamiD KamiD merged commit 50ff03d into dev Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants