Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fq:fix wasm simulate oom #3160

Merged
merged 5 commits into from Jun 7, 2023
Merged

fq:fix wasm simulate oom #3160

merged 5 commits into from Jun 7, 2023

Conversation

scf0220
Copy link
Contributor

@scf0220 scf0220 commented Jun 1, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Merging #3160 (2461061) into dev (2420a8b) will increase coverage by 0.00%.
The diff coverage is 12.19%.

❗ Current head 2461061 differs from pull request most recent head 2364b8e. Consider uploading reports for the commit 2364b8e to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev    #3160   +/-   ##
=======================================
  Coverage   36.58%   36.59%           
=======================================
  Files         442      442           
  Lines       46428    46436    +8     
=======================================
+ Hits        16988    16993    +5     
- Misses      28179    28184    +5     
+ Partials     1261     1259    -2     
Impacted Files Coverage Δ
app/rpc/backend/backend.go 0.00% <0.00%> (ø)
x/wasm/simulate.go 0.00% <0.00%> (ø)
x/wasm/keeper/querier.go 70.69% <50.00%> (+0.65%) ⬆️
x/wasm/keeper/keeper.go 80.00% <57.14%> (+0.14%) ⬆️

@KamiD KamiD merged commit 6bb6ffc into dev Jun 7, 2023
6 of 7 checks passed
@scf0220 scf0220 deleted the scf/fix-fq-wasm-oom branch June 7, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants