Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Apollo configuration #37

Merged
merged 53 commits into from
Jul 9, 2024
Merged

Integrate Apollo configuration #37

merged 53 commits into from
Jul 9, 2024

Conversation

sieniven
Copy link

@sieniven sieniven commented Jun 25, 2024 •
edited
Loading

Summary

  • Add Apollo client into Erigon node to support apollo configuration management
  • Add support for jsonrpc, sequencer and l2gaspricer prefix namespace pipelines for config management of these services
  • Add callbacks to load of node and eth configs from apollo config changes
  • Add support for dynamic config changes with apollo config singleton instances on ethconfig and nodeconfig
  • Depends on refactors from PR Fix config initialization failure on start up, clean up configs #53

@sieniven sieniven mentioned this pull request Jun 27, 2024
Merged
@sieniven sieniven force-pushed the niven/apollo branch 2 times, most recently from 1451f2f to 7fbbc6c Compare July 1, 2024 09:27
giskook
giskook reviewed Jul 5, 2024
View reviewed changes
eth/ethconfig/config_xlayer.go Show resolved Hide resolved
cmd/utils/flags.go Outdated Show resolved Hide resolved
eth/ethconfig/apollo_xlayer.go Show resolved Hide resolved
@sieniven sieniven changed the base branch from dev to niven/fix-config-flags July 5, 2024 07:09
@sieniven
Copy link
Author

sieniven commented Jul 5, 2024 •
edited
Loading

Retargetting to niven/fix-config-flags for now for easier review since this PR depends on the fixes in PR #53. Will retarget to dev once that PR is in.

@sieniven sieniven changed the base branch from niven/fix-config-flags to dev July 9, 2024 01:55
@KamiD KamiD merged commit 2fc44bf into dev Jul 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giskook giskook giskook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sieniven @giskook @KamiD