Update clustercheck

[Newbeeee]

syntax error

[Cougar]

The problem is only with MYSQL_USERNAME but your fix is wrong here. Your change won't keep empty variable and therefore it is not possible to put username and password in /etc/my.cnf. I didn't find it in bash manual but this is how the MYSQL_PASSWORD works ('!' is not allowed in command line):

>echo "${MYSQL_PASSWORD-clustercheckpassword}"
clustercheckpassword
>export MYSQL_PASSWORD=''; echo "${MYSQL_PASSWORD-clustercheckpassword}"

>export MYSQL_PASSWORD='x'; echo "${MYSQL_PASSWORD-clustercheckpassword}"
x

but

>export MYSQL_PASSWORD=''; echo "${MYSQL_PASSWORD:-clustercheckpassword}"
clustercheckpassword

In second case the

percona-clustercheck/clustercheck

Lines 52 to 54 in d5da8be

	if [[ -n "$MYSQL_PASSWORD" ]]; then
	EXTRA_ARGS="$EXTRA_ARGS --password=${MYSQL_PASSWORD}"
	fi

condition doesn't add --password parameter which is intentional. Otherwise it always overrides password in /etc/my.cnf.

The same should be with MYSQL_USERNAME.

With :- syntax it is not possible to have empty variable and

percona-clustercheck/clustercheck

Lines 49 to 54 in d5da8be

	if [[ -n "$MYSQL_USERNAME" ]]; then
	EXTRA_ARGS="$EXTRA_ARGS --user=${MYSQL_USERNAME}"
	fi
	if [[ -n "$MYSQL_PASSWORD" ]]; then
	EXTRA_ARGS="$EXTRA_ARGS --password=${MYSQL_PASSWORD}"
	fi

is pointless.