-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Chinese time #30
Conversation
@olebedev here |
Hey @quxiaolong1504, Thank you for your contribution. However, I am not sure if I am qualified to verify the language-specific stuff here. From the perspective of the code structure and testing it looks good to me 👍 Before merging, I would like to see some test results. Can you rebase of this #31 so we can see in it your PR? |
No idea why it hasn't been triggered. I checked out the branch and got an error:
|
How is the issue going, this function is really great, looking forward to it! |
@quxiaolong1504, friendly ping |
Hello @5idu, I noticed your interest in this feature. Would you be willing to take over from @quxiaolong1504 and work on it? I believe this is the only remaining step needed to complete it. That would be fantastic while we wait for @quxiaolong1504. Best regards, |
Hey @quxiaolong1504, do you think this one is still relevant, given we already have most of the change landed in this #39 PR? Feel free to close it, if you think it's appropriate :) |
Support Chinese time parse
Example:
AfterTime
后天中午
下月6号
Weekday
下周三
下下周二