Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewriteRules: type rewrite rules better #379

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

julesvirallinen
Copy link
Contributor

closes #289

I've been testing this in my personal garden for a few weeks now, and it works well!

why

  • adding blank paths creates faulty garden paths
  • there is currently no way to set a base garden path that maps to root.

what

  • change typing for rewrite rules to explicit object
  • fix empty path
  • remove skip from test added in previous PR

Questions for @oleeskild

  • would you be fine with me adding prettier / linter rules?
    • I see there's editorconfig, but it only standardizes a couple things, which makes editing super hard
  • for linting I would add at least removing unused imports and maybe other standard base rules / typescript niceties
  • prettier-styling would be higher priority though :D

@oleeskild
Copy link
Owner

Awesome, thanks 🙌 Will merge it in, do some testing, and include it in today's release.

About linting: Yes please. Never bothered to add it, as I didn't expect many PRs/collaborators. Now that the project has grown, and gets a fair amount of PRs there really is need for some linting. It will make reviewing PRs a lot easier also. I'm not very picky about what specific rules and code-styles should be used. The important thing is that they exist 😅

@oleeskild oleeskild merged commit 3050693 into oleeskild:main Sep 5, 2023
@julesvirallinen
Copy link
Contributor Author

@oleeskild yes awesome, I'll do that. I have a major peeve for unlinted code :D

@julesvirallinen julesvirallinen deleted the allowBlankRewritePath branch September 13, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Setting Path Rewrite Rule to Base URL
2 participants