More robust algorithm and backend rewrite in Node #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
This is the first iteration of the algorithm / library which will be shared by both frontend and backend. It is very simple at the moment, but can be expanded. Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
In preparation for changing positions to use row / column. Negative indices can be reimplemented later, if necessary. Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
olehermanse
force-pushed
the
node
branch
3 times, most recently
from
c2415f5
to
3c25152
Compare
The change events in ace editor look something like this:
```
{"start":{"row":1,"column":4},"action":"insert","lines":["o"]}
{"start":{"row":1,"column":5},"action":"insert","lines":["",""]}
```
(Simplified)
So, the new libbuf API aligns with this. The 2 main advantages are:
* Easy to implement, frontend doesn't have to translate events
* Concurrent editing on separate lines should just work
There's still more work to do to make the algorithm more robust,
but I think this is good enough for now. It should be better
than the old version that is deployed currently.
Both inserting and removing seems to work well, both in unit tests
and in editor.
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
Signed-off-by: Ole Herman Schumacher Elgesem <oleherman93@gmail.com>
michaelpande
approved these changes
Apr 21, 2020
|
@michaelpande Takk, alle kommentarene dine er besvart, og follow-up er her: #44 |
|
Bare hyggelig 😊
…On Sun, Apr 26, 2020 at 2:23 AM Ole Herman Schumacher Elgesem < ***@***.***> wrote:
@michaelpande <https://github.com/michaelpande> Takk, alle kommentarene
dine er besvart, og follow-up er her: #44
<#44>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#43 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACDCCR3XGVZ6P5375AEHBSTRON5JFANCNFSM4MM37OHQ>
.
|
olehermanse
added a commit
that referenced
this pull request
Apr 27, 2020
Addressed review comments from #43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Algorithm loosely based on:
https://www.duo.uio.no/handle/10852/53012