Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin and Compose updates #8

Closed
wants to merge 3 commits into from
Closed

Kotlin and Compose updates #8

wants to merge 3 commits into from

Conversation

GuilhE
Copy link

@GuilhE GuilhE commented Jul 12, 2023

  • Updates gradles versions to use latest kotlin, compose-compiler, gradle
  • Adds compose-bom from chrisbanes in order to be able to use any compose version (stable, beta, alpha)
  • Overrides new LazyLayoutItemProvider method override fun Item(index: Int, key: Any). NOTE: not using key value, needs check to validate if it's needed.

This will fix #7

@GuilhE
Copy link
Author

GuilhE commented Jul 13, 2023

Tested in my project:

implementation(libs.helpers.compose.tables) {
        exclude(group = "io.github.oleksandrbalan", module = "minabox")
}
implementation("com.github.GuilhE:minabox:feature~sign_disabled-SNAPSHOT")

ir works 🎊

Bumps compose compiler to 1.5.0 stable
@GuilhE
Copy link
Author

GuilhE commented Jul 19, 2023

New version with compose compiler 1.5.0:

implementation(libs.helpers.compose.tables) {
    exclude(group = "io.github.oleksandrbalan", module = "minabox")
}
implementation("com.github.GuilhE:minabox:1.0.0-sign-disabled")

@oleksandrbalan
Copy link
Owner

Thank you for your time and PR, it indeed fixes the problem, but I am planning to move to Compose Multiplatform, which is now capped on Compose 1.4.3. You could fork the library and update it for your needs, as I do not plan to publish also beta library versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash with newer Compose versions starting from 1.5.0-beta01
2 participants