feat: allows JSON type overrides in Decode()
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, `Decode()` can take an optional list of Go types and their respective JSON types which it'll use while decoding the provided payload. **Motivation:** By default, Go structs are treated as JSON objects by the jsonschema validator. However, there may be instances when we may want to override the JSON representation of a type. For example, we may have a custom struct that serves as our own abstraction around a numeric type. The type itself may be a bit more complex than a simple `int` or a `float` but, much like Go's built-in types, we may still simply want to transit its underlying value as a number and deal with the specifics of the abstraction at the application or API level.
oleoneto
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change,
Decode()can take an optional list of Go types and their respective JSON types which it'll use while decoding the provided payload.Motivation:
By default, Go structs are treated as JSON objects by the jsonschema validator. However, there may be instances when we may want to override the JSON representation of a type. For example, we may have a custom struct that serves as our own abstraction around a numeric type. The type itself may be a bit more complex than a simple
intor afloatbut, much like Go's built-in types, we may still simply want to transit its underlying value as a number and deal with the specifics of the abstraction at the application or API level.