Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix movable columns and range selection #4431

Merged

Conversation

azmy60
Copy link
Contributor

@azmy60 azmy60 commented Mar 13, 2024

This PR should allow us to have movable columns and also column range selection. Currently, enabling both options would results in weird behavior.

DEMO (to replicate): https://jsfiddle.net/4pqox6gu/

mygif

@olifolkerd
Copy link
Owner

Hey @azmy60

Looking good there, one quick tip on naming, the Tabulator convention is to use "ing" for when a thing starts and "ed" for when it ends

so it would be column-moving and column-moved if you would be ok with the changes. There is already an existing column-moved event, would the exiting one work for you without needing your new one? it is triggered at about the same time, just from a different point in the code?

Cheers

Oli :)

@azmy60
Copy link
Contributor Author

azmy60 commented Mar 18, 2024

Hey @olifolkerd ,

Yeah, that's fine. The code still works with the existing event.

@marsrover4
Copy link

could someone please merge this? 0:)

@olifolkerd olifolkerd merged commit f7708fe into olifolkerd:master Apr 28, 2024
1 of 3 checks passed
@marsrover4
Copy link

Thanks for the merge! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants