add switch_server method

[s4w3d0ff]

still needs to handle the registered entity event listeners
not sure how to go about this but I'm assuming that you need to iterate through the current registered listeners, if the listener is an instance of EntityEvent then remove it.

also have no idea how to restart the socket after disconnecting it, is it await self.connect() or does it need to be added to the current asyncio loop?

[s4w3d0ff]

I also haven't tested this yet

[olijeffers0n]

Thanks for the PR! I have left a few comments but feel free to message on discord with regards to the entity listeners

[s4w3d0ff]

I dont know what happened lol the tabs are 8 spaces wide and I cant get them to change to 4 spaces like how the rest of the repo is

[olijeffers0n]

More Changes

[olijeffers0n]

That should be the Remote & Command stuff all done, just need to remove the entity events. They are set as attributes to the EventHandler iirc

[s4w3d0ff]

from my understanding the attribute names are the ids of the entities? maybe vars(self.remote.event_handler) will work, or vars(self) if you want to add a method like EventHandler.clear_entity_events() then iterate the value of vars(self) and isinstance(x, EntityEvent)

[olijeffers0n]

Thanks, I cannot test this right now but the diff looks good. One thing - are you expecting the tabs and spaces to be fine?

[s4w3d0ff]

I just downloaded and ran this branch, rn it seems that method hangs on await self.disconnect at line 178 not sure why

[s4w3d0ff]

I didnt get a tabs/space error so it seems to be fine

[s4w3d0ff]

tested and seems to be working

[s4w3d0ff]

The entity listeners and command handler I didn't test, my bot doesn't use them (but probably will in the future) and I didn't write a test script for them.

[olijeffers0n]

Seems ok for now. Command handler is fixed but haven't tested the entity events. If someone could that would be appreciated :)

[olijeffers0n]

Hmm, I am confused as to the root cause of super.close() hanging the thing. What does shutdown do differently?

[s4w3d0ff]

From what I understand, close() (https://github.com/websocket-client/websocket-client/blob/master/websocket/_core.py#L458) sends some data to the connected server to tell it to stop sending data (sort of an "unsubscribe") while shutdown() will just close the socket immediately regardless. Could also try send_close() first before the shutdown() to still send that "unsubscribe" message https://github.com/websocket-client/websocket-client/blob/master/websocket/_core.py#L442

But I have no clue why close() isn't working

[s4w3d0ff]

Just saw this issue: websocket-client/websocket-client#592 seems to be similar to what I had experienced.

[olijeffers0n]

LGTM