Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events with no location export with location = “none” string #93

Closed
osteele opened this issue Aug 29, 2017 · 3 comments
Closed

Events with no location export with location = “none” string #93

osteele opened this issue Aug 29, 2017 · 3 comments

Comments

@osteele
Copy link
Contributor

osteele commented Aug 29, 2017

To reproduce:

Expected:

  • Events with no location will not display location text in the Google Calendar day, week, or month views; e.g. “Labor Day”

Actual:

  • Events with no location display “none” as the location; e.g. “Labor Day – none”. See screenshots.

Screen shots

ABE event

screenshot of safari 8-29-17 8-21-13 am

Google Calendar month view

screenshot of safari 8-29-17 8-22-51 am

Google Calendar event detail

screenshot of safari 8-29-17 8-23-13 am

@kylecombes
Copy link
Collaborator

This is a backend issue more than a frontend issue (issue opened), but I suppose we could make sure we don't send location if it's empty. Currently it looks like we'll send an empty string.

@kylecombes kylecombes added this to the Release v1.3 milestone Sep 1, 2017
@kylecombes kylecombes added the bug label Apr 2, 2018
@kylecombes
Copy link
Collaborator

We should probably not have anything for location in the event data that goes to the server if the location field is blank. Then we'll need to make sure the backend knows not to export None (which looks like a Python artifact) when generating an ICS feed.

@kylecombes
Copy link
Collaborator

You'll want to use the Firefox developer tools to watch what data is being sent back and forth to the server.

@kylecombes kylecombes modified the milestones: Release v1.3, Release v2.0 Apr 9, 2018
@osteele osteele closed this as completed May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants