Initial mode picker #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
In action: |
|
@MatthewBeaudouinLafon and I talked about some next steps: making |
|
Rebased off of new master |
|
I refactored some more, 132004a has the details. |
|
Ready for a look-through, those last two are just formatting changes. |
labseven
approved these changes
May 8, 2019
Lots of changes here:
- mode functions are now called only with a "reason" and the state
- reasons are explained more on Line 18 of fe_modes.c
- the only function that was using canvas_win or status_win was
mode_brush, which was using it as a hacky way of clearing the
status window
- declare new functions with mode_function_t in fe_modes.h
- mode_master renamed to master_handler and is now less of a mode.
- run continuously in main loop
- grabs keys with wgetch
- handles global keypresses and UI updates
- mode calling and switching is a little more complex but now
factored out into call_mode and switch_mode
|
Added some changes from comments, this should be good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a rough mode picker interface to use brush mode with, and refactored some of the mode code in the process.
Closes #15.
TODO:
add mode-level configssee Add mode-level configs #52