Skip to content

Conversation

@newsch
Copy link
Member

@newsch newsch commented May 5, 2019

Brush Mode: paint with a character.

┌─────────────────────────────────────────────────┐
│BBB  RRR  U  U SSSS H  H                         │
│B  B R  R U  U S    H  H                         │
│BBB  RRR  U  U SSSS HHHH                         │
│B  B R R  U  U    S H  H                         │
│BBB  R  R UUUU SSSS H  H                         │
│                                                 │
│M  M OOOO DDD  EEEE                              │
│MMMM O  O D  D E                                 │
│M  M O  O D  D EEE                               │
│M  M O  O D  D E                                 │
│M  M OOOO DDD  EEEE                              │
│                                                 │
│                                                 │
│                                                 │
├─────────────────────────────────────────────────┤
│state: OFF     brush: 'E' (Press ENTER to toggle)│
│                                                 │
└─────────────────────────────────────────────────⏎ 

@newsch newsch self-assigned this May 5, 2019
@newsch newsch added the enhancement New feature or request label May 5, 2019
@newsch newsch marked this pull request as ready for review May 5, 2019 20:40
@newsch newsch mentioned this pull request May 6, 2019
@newsch
Copy link
Member Author

newsch commented May 6, 2019

One twist I found: enabling mouse support hijacks the normal method of highlighting for copy-pasting. On my machine with gnome-terminal I need to SHIFT-click to highlight lines and SHIFT-CTRL-click to block-select.

@newsch
Copy link
Member Author

newsch commented May 6, 2019

@MatthewBeaudouinLafon @labseven you should try out mouse support on your machines and see if it works there. I'm not sure how flexible this solution is.

@newsch newsch added this to the MVP milestone May 6, 2019
@newsch newsch mentioned this pull request May 6, 2019
4 tasks
@newsch
Copy link
Member Author

newsch commented May 6, 2019

Rebased the mode picker stuff into #45 to separate things out.

@newsch
Copy link
Member Author

newsch commented May 6, 2019

In a fun twist of fate, util.h now throws unused warnings about _log_unused when DEBUG IS defined.

@newsch
Copy link
Member Author

newsch commented May 6, 2019

Fixed by declaring the function as inline.

@newsch newsch added interface and removed interface labels May 6, 2019
@newsch newsch merged commit f7329e5 into master May 7, 2019
@newsch
Copy link
Member Author

newsch commented May 7, 2019

Whoops, I forgot to rebase this first.

@newsch newsch mentioned this pull request May 7, 2019
@newsch
Copy link
Member Author

newsch commented May 7, 2019

AND I didn't push the update for MacOS. Oof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants