Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript error on 'next' #858

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Fix TypeScript error on 'next' #858

merged 2 commits into from
Mar 18, 2020

Conversation

crutchcorn
Copy link
Member

@crutchcorn crutchcorn commented Mar 18, 2020

What's Changing and Why

TS tests seem to be failing in #857. I am unable to recreate this issue on my local machine, but I'm hoping this fixes it on CI (I think my local machine simply isn't getting next on TS properly)

What else might be affected

Tasks

  • Add tests
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label

Published PR with canary version: 0.9.6-canary.858.667.0

@hipstersmoothie hipstersmoothie added internal Changes only affect the internal API skip-release Preserve the current version when merged labels Mar 18, 2020
@crutchcorn
Copy link
Member Author

Well golly. I guess it's time to figure out the TS next caching issue on my machine to debug further.

@hipstersmoothie
Copy link
Collaborator

We could also try to limit it to not test @next, but I couldn't find that in the docs

@crutchcorn
Copy link
Member Author

crutchcorn commented Mar 18, 2020

We could do that as well, but I'm not able to find a way to test other versions of TS in a range without selecting next either. Let me see if I can't fix this quickly - it'd be a shame if TS3.8 came out and we got a new batch of issues, ya know?

@crutchcorn
Copy link
Member Author

Apologies for taking so long - I found a bug with TS itself that we can't work around that was impacting some type issues. I decided to edge-case that bug while I was already in the weeds of things. That said, this should work for next as well as the other versions. I was able to get the bugs showing on my local machine and they no longer do. Let's hope CI passes

@hipstersmoothie
Copy link
Collaborator

This was a super quick response! Thanks for taking a look (and for helping me maintain jimp ❤️ )

@hipstersmoothie
Copy link
Collaborator

🚀 PR was released in v0.9.6 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants