Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use promhttp.ContinueOnError to not fail on duplicate metrics #321

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

oliver006
Copy link
Owner

@oliver006 oliver006 commented Oct 8, 2019

Fixes #315

@oliver006 oliver006 self-assigned this Oct 8, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 81.379% when pulling f46d1f6 on oh_continue_on_error into 2d7b644 on master.

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #321 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #321     +/-   ##
=========================================
+ Coverage   78.03%   78.14%   +0.1%     
=========================================
  Files           2        2             
  Lines         824      828      +4     
=========================================
+ Hits          643      647      +4     
  Misses        148      148             
  Partials       33       33
Impacted Files Coverage Δ
exporter.go 88.02% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d7b644...f46d1f6. Read the comment docs.

@oliver006 oliver006 merged commit c3213a1 into master Oct 8, 2019
@oliver006 oliver006 deleted the oh_continue_on_error branch October 8, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 500 on /metrics page with Google Cloud Memorystore
2 participants