Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update client info parsing to accept IPv6 addr #864

Merged
merged 2 commits into from
Dec 28, 2023
Merged

update client info parsing to accept IPv6 addr #864

merged 2 commits into from
Dec 28, 2023

Conversation

edward-milkey
Copy link
Contributor

This PR addresses issue #863. parseClientListString is updated to parse IPv6 addresses.

@coveralls
Copy link

coveralls commented Dec 22, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 237

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 92.103%
Changes Missing Coverage Covered Lines Changed/Added Lines %
exporter/clients.go 4 5 80.0%
Totals Coverage Status
Change from base Build 235: -0.04%
Covered Lines: 1971
Relevant Lines: 2140
💛 - Coveralls

oliver006
oliver006 approved these changes Dec 24, 2023
View reviewed changes
Copy link
Owner

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Two minor comments/questions but this looks good.

exporter/clients.go Show resolved Hide resolved
exporter/clients.go Outdated Show resolved Hide resolved
@oliver006 oliver006 merged commit 8b2b2e9 into oliver006:master Dec 28, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver006 oliver006 oliver006 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edward-milkey @coveralls @oliver006