Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate extension methods to child namespaces #7

Closed
oliverbooth opened this issue Jan 14, 2021 · 2 comments
Closed

Relocate extension methods to child namespaces #7

oliverbooth opened this issue Jan 14, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request triaged High-priority issue
Milestone

Comments

@oliverbooth
Copy link
Owner

The rationale:

The consumer can decide which types to extend by only importing the necessary namespace. This will avoid conflicts with other libraries where the euser must resolve name collision by fully qualifying a static invocation.

@oliverbooth oliverbooth added the enhancement New feature or request label Jan 14, 2021
@oliverbooth oliverbooth added this to the 3.0.0 milestone Jan 14, 2021
@oliverbooth oliverbooth self-assigned this Jan 14, 2021
@oliverbooth
Copy link
Owner Author

oliverbooth commented Jan 17, 2021

Commit 17f6a05 contributes to this issue despite referencing #17 by mistake

oliverbooth added a commit that referenced this issue Jan 17, 2021
oliverbooth added a commit that referenced this issue Jan 18, 2021
oliverbooth added a commit that referenced this issue Jan 18, 2021
oliverbooth added a commit that referenced this issue Jan 18, 2021
oliverbooth added a commit that referenced this issue Jan 18, 2021
Also relocate to child namespace.

Resolves #8 and is item for #7
oliverbooth added a commit that referenced this issue Mar 7, 2021
- GetString renamed to ToString
- No longer has optional Encoding parameter
oliverbooth added a commit that referenced this issue Mar 7, 2021
- Deprecate Random methods in favour of RandomExtensions methods
oliverbooth added a commit that referenced this issue Mar 10, 2021
Avoids collision when importing both X10D.RandomExtensions and
X10D.Unity.RandomExtensions
@oliverbooth
Copy link
Owner Author

Fully resolved as of 61da369

@oliverbooth oliverbooth added triaged High-priority issue and removed invalid This doesn't seem right labels Apr 21, 2022
oliverbooth added a commit that referenced this issue Apr 22, 2022
Also introduces TryWriteHash
oliverbooth added a commit that referenced this issue Apr 25, 2022
Also renames more tests to be more meaningful
oliverbooth added a commit that referenced this issue Apr 30, 2022
oliverbooth added a commit that referenced this issue Apr 30, 2022
* Finalizes unit tests, 99% coverage
* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged High-priority issue
Projects
None yet
Development

No branches or pull requests

1 participant