Ignore when removing a non-existent document on the index #24
Conversation
| @@ -51,6 +51,21 @@ test('removing a document from the index', function () { | |||
| equal(idx.documentStore.length, 0) | |||
| }) | |||
|
|
|||
| test('removing a non-existent document from the index', function () { | |||
| var idx = new lunr.Index, | |||
| doc = {id: 1, body: 'this is a test'} | |||
There was a problem hiding this comment.
You've missed out a comma here, so doc2 is a global.
Other than that this change looks good, if you add the missing comma then I can merge this in and create a new release, thanks.
There was a problem hiding this comment.
Ok, I'll take a look later :-)
El 07/05/2013 10:51, "Oliver Nightingale" notifications@github.com
escribió:
In test/index_test.js:
@@ -51,6 +51,21 @@ test('removing a document from the index', function () {
equal(idx.documentStore.length, 0)
})+test('removing a non-existent document from the index', function () {
- var idx = new lunr.Index,
doc = {id: 1, body: 'this is a test'}You've missed out a comma here, so doc2 is a global.
Other than that this change looks good, if you add the missing comma then
I can merge this in and create a new release, thanks.—
Reply to this email directly or view it on GitHubhttps://github.com//pull/24/files#r4109226
.
There was a problem hiding this comment.
Done, now you can fetch it :-) I'm not used to declare variables this way,
I use a var instance per variable... :-)
2013/5/7 piranna@gmail.com piranna@gmail.com
Ok, I'll take a look later :-)
El 07/05/2013 10:51, "Oliver Nightingale" notifications@github.com
escribió:In test/index_test.js:
@@ -51,6 +51,21 @@ test('removing a document from the index', function () {
equal(idx.documentStore.length, 0)
})+test('removing a non-existent document from the index', function () {
- var idx = new lunr.Index,
doc = {id: 1, body: 'this is a test'}You've missed out a comma here, so doc2 is a global.
Other than that this change looks good, if you add the missing comma then
I can merge this in and create a new release, thanks.—
Reply to this email directly or view it on GitHubhttps://github.com//pull/24/files#r4109226
.
"Si quieres viajar alrededor del mundo y ser invitado a hablar en un monton
de sitios diferentes, simplemente escribe un sistema operativo Unix."
– Linus Tordvals, creador del sistema operativo Linux
Ignore when removing a non-existent document on the index
|
This fix is now available in version 0.3.1, thanks for the patch! |
|
Welcome :-)
|
No description provided.