Add multi-term support to Query#term #341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a single term could be passed to the Query#term method, additionally this term needed to be a string. No tokenization is performed by this method. The API was a bit cumbersome when dealing with user entered queries, tokenization had to be done manually, and then the results manually iterated over and used with Query#term. This change improves matters in two ways: * Lists of terms are supported * A term can be anything that responds to `toString` Together these two changes make it possible to directly use the lunr.tokenizer when passing strings to Query#term.
|
This has now been merged into master and is released in version 2.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a single term could be passed to the Query#term method,
additionally this term needed to be a string. No tokenization is
performed by this method. The API was a bit cumbersome when dealing
with user entered queries, tokenization had to be done manually, and
then the results manually iterated over and used with Query#term.
This change improves matters in two ways:
toStringTogether these two changes make it possible to directly use the
lunr.tokenizer when passing strings to Query#term.