refactor(ui): Simplify header elements

oliversalzburg · Oct 8, 2022 · 7b10ad2 · 7b10ad2
1 parent a37fb6f
commit 7b10ad2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 16 deletions.
diff --git a/packages/userscript/source/ui/SettingsSectionUi.ts b/packages/userscript/source/ui/SettingsSectionUi.ts
@@ -79,13 +79,7 @@ export abstract class SettingsSectionUi {
    * @returns The constructed header element.
    */
   protected _getHeader(text: string): JQuery<HTMLElement> {
-    const headerElement = $("<li/>");
-    const header = $("<span/>", {
-      text,
-    }).addClass("ks-header");
-
-    headerElement.append(header);
-
+    const headerElement = $("<li/>", { text }).addClass("ks-header");
     return headerElement;
   }
 
@@ -97,14 +91,8 @@ export abstract class SettingsSectionUi {
    * @returns The constructed header element.
    */
   protected _getExplainer(text: string): JQuery<HTMLElement> {
-    const headerElement = $("<li/>");
-    const header = $("<span/>", {
-      text,
-    }).addClass("ks-explainer");
-
-    headerElement.append(header);
-
-    return headerElement;
+    const explainerElement = $("<li/>", { text }).addClass("ks-explainer");
+    return explainerElement;
   }
 
   protected _getBuildOption(

diff --git a/packages/userscript/source/ui/UserInterface.ts b/packages/userscript/source/ui/UserInterface.ts
@@ -164,7 +164,7 @@ export class UserInterface {
     );
     // Hover guides
     this._addRule(
-      `#ks > ul > li li:hover { 
+      `#ks > ul > li .ks-setting:hover { 
         border-bottom: 1px solid rgba(185, 185, 185, 0.5);
       }`
     );