Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player-owned private companies are displayed as minor companies #35

Closed
ollybh opened this issue Nov 20, 2022 · 1 comment
Closed

Player-owned private companies are displayed as minor companies #35

ollybh opened this issue Nov 20, 2022 · 1 comment
Assignees
@ollybh
Labels
1858 Affects the 1858 implementation enhancement New feature or request

Comments

@ollybh
Copy link
Owner

ollybh commented Nov 20, 2022

Privates owned by players are rendered using View::Game::Corporation.render which is attempting to show previous revenue, and the company names aren't fitting in the tiles.

It would be better to use a similar format to the one for unsold private companies. The rendering can be overridden through a setting in @game.corporation_view, see 1872 for example.
@ollybh ollybh added enhancement New feature or request 1858 Affects the 1858 implementation labels Nov 20, 2022
@ollybh ollybh self-assigned this Nov 20, 2022
@ollybh
Copy link
Owner Author

ollybh commented Nov 22, 2022

Fixed in commit 578e426.

@ollybh ollybh closed this as completed Nov 22, 2022
ollybh added a commit that referenced this issue Nov 24, 2022
@ollybh
[1858] Render player-owned private companies as privates not minors
578e426 
Override the default rendering for private railway companies that
are owned by players. These would be rendered as minor companies
(with treasury, trains and revenue). Instead render them in the same
way as private companies that are owned by the bank.

Fixes #35.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ollybh ollybh

Labels
1858 Affects the 1858 implementation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ollybh