Fixes iOS and Android Splash Screens #159
Conversation
ggirotto
added
enhancement
There was a problem hiding this comment.
Is this a temporary solution? It doesn't seems to me that it's an assumed solution, given how there's no associated Flutter issue with this (and it's clearly an issue with the framework then).
Also, does this occurs on Android devices as well for you to update the Android solution?
|
Maybe a regression issue? Loosely related: flutter/flutter#37155 |
|
Why do you believe this is not an assumed solution? Using the native splash screens avoids any possible Flutter problem and it's definitely the optimal solution, since it uses the native way of handling with splash screens instead relying on Flutter framework lifecycle. I also updated Android because now the splash screen appears faster. I don't think that #37155 is the same issue that we're facing, since the OP reports that the app freeze at the black screen, and we just have an unexpected delay (maybe Flutter framework initialize delay, not sure) |
There was a problem hiding this comment.
Why do you believe this is not an assumed solution? Using the native splash screens avoids any possible Flutter problem and it's definitely the optimal solution, since it uses the native way of handling with splash screens instead relying on Flutter framework lifecycle.
Well, if you're going that way, I could say the same for "implementing native UI screens is the optimal solution". If it's out of Flutter's scope of handling stuff, I would totally agree with you, such as handling camera usage, audio-related operations, etcetera. - we could even possibly create a plugin for such thing -, but again, I don't believe this case. A splash screen is something that's not required, but it's a standard that all mobile applications, and it's definitely something that we should expect from Flutter's framework - and after all, it's just a screen.
What I feel from this is simply a limitation - or some bug - with Flutter, thus why it doesn't feel to me like a solution, more like a workaround.
|
I disagree this is a workaround, since it's suggested even in the Flutter docs. They state the same that I believe:
If there is the possibility of Flutter engine delays it initialization, we cannot rely on it Flutter to provide a solution to the problem. They also state:
Which is the exactly description about this issue. They propose a "Flutter" solution that uses a Android View, which I personally believe that it's worst from the platform-related solution proposed by this PR |
There was a problem hiding this comment.
I disagree this is a workaround, since it's suggested even in the Flutter docs.
Indeed, this is what the Flutter's team recommends to do - I was completely wrong. Interesting article, haven't seen this one when I read the docs last time!
Nonetheless, I still feel like this is something that we could think about improving, although I think it won't be trivial. My only argument to why this can lead to future problems is that a future change to the SplashPage is not guaranteed to be equal in both native platforms, that's my only concern with 3 different ecosystems requiring the exact same interface, that may change over time. Even though this is the ideal solution, given the cited article, I suggest it to have a little succinct section in our ARCHITECTURE, as a reference for future changes. This sections is a nitpick, it's up to you to add it.
Fixes #130