fix: prevent negated patterns from traversing directory boundaries #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlyon
force-pushed
the
fix/negated-dir-traversal
branch
from
a34cc23
to
066ce98
Compare
olson-sean-k
requested changes
Sep 13, 2023
|
Thanks for the PR and sorry for the radio silence! If you're still willing to land this, please let me know and take a look at the review. I realize this change was requested some time ago and I completely understand if you can't or don't want to get this landed now. |
olson-sean-k
force-pushed
the
fix/negated-dir-traversal
branch
from
df19cbe
to
802b0d9
Compare
This change factors out some common code in class encoding and collapses branches into a single branch. It also consolidates related tests into a somewhat more general test case.
|
Hey! Apologies for just abandoning this, been very busy recently. I appreciate you taking the time to merge this 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40 by not pushing &&[^/] if we are already in a negation pattern, and just pushing the separator instead.