Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#159269831 Make features section in homepage visible #14

Merged
merged 2 commits into from
Jul 25, 2018

Conversation

olusoladavid
Copy link
Owner

@olusoladavid olusoladavid commented Jul 25, 2018

What does this PR do?

Makes the features section of the homepage visible to the user immediately after landing on the page. In the previous version, the hero section stretched to fill the height of the viewport thereby making the features section non-visible. This has been corrected to improve the user's experience on the landing page.

Description of Task to be completed

  • Add the appropriate CSS classes
  • Update the markup of the homepage (index.html)
  • Ensure new change is responsive (displays well on smaller devices)

How should this be manually tested?

Review the changed files and see attached screenshots:

Screenshot Desktop

Screenshot Mobile

What are the relevant pivotal tracker stories?

#159269831

@olusoladavid olusoladavid added the enhancement New feature or request label Jul 25, 2018
@coveralls
Copy link

coveralls commented Jul 25, 2018

Pull Request Test Coverage Report for Build 45

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 35: 0.0%
Covered Lines: 51
Relevant Lines: 51

💛 - Coveralls

Copy link
Collaborator

@andela-ookoro andela-ookoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work, this is good

@olusoladavid olusoladavid merged commit 557e1ce into develop Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants