-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#159328663 Create PUT /entries/:id endpoint #28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create SQL queries - Verify JWT - Create GET endpoint controller - Return array of entries [Delivers #159352571]
- Changes were made to ft-login-endpoint-159328012 - Merge the changes to relect in ft-get-all-entries-159352571
- Create SQL queries - Create POST endpoint - Validate user inputs - Return JWT [Delivers #159328304]
- Create SQL queries - Create GET endpoint - Verify JWT - Return single entry [Delivers #159328442]
- Create SQL queries - Create PUT endpoint controller - Validate user inputs - Return entry [Delivers #159328663]
Pull Request Test Coverage Report for Build 94
💛 - Coveralls |
FredDominant
reviewed
Aug 2, 2018
.isBoolean() | ||
.optional(), | ||
], | ||
booleanOrNull: bool => (typeof bool === 'undefined' ? null : bool), | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use classes here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates the PUT /entries/:id endpoint for users to modify a single entry
Description of Task to be completed
How should this be manually tested?
npm run test
What are the relevant pivotal tracker stories?
#159328663